From 25fe2af932be6bc8cf022992a32676c4b415de9b Mon Sep 17 00:00:00 2001
From: Jesus Galaz <jesusgalazr@icloud.com>
Date: Wed, 6 Nov 2024 17:45:30 +0100
Subject: [PATCH] Implementing "Secure database" issue
---
docker-compose.yml | 10 ++++++++--
mongodb.js | 9 ++++++---
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/docker-compose.yml b/docker-compose.yml
index 1d21bd3..cb7d10c 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -4,13 +4,19 @@ services:
container_name: mongodb
ports:
- "27017:27017"
+ environment:
+ - MONGO_INITDB_ROOT_USERNAME=${MONGO_INITDB_ROOT_USERNAME}
+ - MONGO_INITDB_ROOT_PASSWORD=${MONGO_INITDB_ROOT_PASSWORD}
+ - MONGO_INITDB_DATABASE=todo-app
todo-app:
- image: todo-app
+ build:
+ context: .
+ dockerfile: Dockerfile
container_name: todo-app
ports:
- "80:3000"
depends_on:
- mongodb
environment:
- - MONGO_URI=mongodb://mongodb:27017/todo-app
+ - MONGO_URI=${MONGO_URI}
diff --git a/mongodb.js b/mongodb.js
index 8863f0e..d953917 100644
--- a/mongodb.js
+++ b/mongodb.js
@@ -1,9 +1,12 @@
-const mongoose = require('mongoose');
-require('dotenv').config();
+const mongoose = require("mongoose");
+require("dotenv").config();
const connectDB = async () => {
try {
- const conn = await mongoose.connect(process.env.MONGO_URI || "mongodb://mongodb:27017/todo-app");
+ const conn = await mongoose.connect(process.env.MONGO_URI, {
+ useNewUrlParser: true,
+ useUnifiedTopology: true,
+ });
console.log(`MongoDB connected: ${conn.connection.host}`);
} catch (err) {
console.error(`Error: ${err.message}`);
--
GitLab