diff --git "a/Test_Converter_R\303\266mische_Zahlen.py" "b/Test_Converter_R\303\266mische_Zahlen.py" index e8658c9c779e5671f7c2786da640ac82795ea5e1..a08c9de866d9c3bf9c33965b1e617b097e1984d1 100644 --- "a/Test_Converter_R\303\266mische_Zahlen.py" +++ "b/Test_Converter_R\303\266mische_Zahlen.py" @@ -5,6 +5,7 @@ from abc import ABC, abstractmethod #from muhamed_directory.other.alma.test2converter import RomanNumber as Alma #from muhamed_directory.other.daniel.converter import Converter as Dani #from muhamed_directory.other.hatice.converter import RomanNumber as Hati +from muhamed_directory.other.lasse.romannumerals import RomanNumerals as Lasse class IStringCalculator(ABC): @abstractmethod @@ -27,52 +28,32 @@ class Converter(IStringCalculator): return result -'''class TestRomanConverter(unittest.TestCase): +class TestRomanConverter(unittest.TestCase): def setUp(self): - self.calculator = Hati + self.calculator = Lasse def test_1(self): - self.assertEqual(self.calculator.convert(1), "I") + self.assertEqual(self.calculator.to_roman(1), "I") def test_10(self): - self.assertEqual(self.calculator.convert(10), "X") + self.assertEqual(self.calculator.to_roman(10), "X") def test_21(self): - self.assertEqual(self.calculator.convert(21), "XXI") + self.assertEqual(self.calculator.to_roman(21), "XXI") def test_50(self): - self.assertEqual(self.calculator.convert(50), "L") + self.assertEqual(self.calculator.to_roman(50), "L") def test_100(self): - self.assertEqual(self.calculator.convert(100), "C") + self.assertEqual(self.calculator.to_roman(100), "C") def test_1000(self): - self.assertEqual(self.calculator.convert(1000), "M") + self.assertEqual(self.calculator.to_roman(1000), "M") def test_1999(self): - self.assertEqual(self.calculator.convert(1999), "MCMXCIX")''' -class TestRomanConverter(unittest.TestCase): - def setUp(self): - self.converter = Converter + self.assertEqual(self.calculator.convert(1999), "MCMXCIX") - def test_single_value(self): - self.assertEqual(self.converter.convert(1), "I") - self.assertEqual(self.converter.convert(2), "II") - self.assertEqual(self.converter.convert(3), "III") - self.assertEqual(self.converter.convert(4), "IV") - self.assertEqual(self.converter.convert(5), "V") - self.assertEqual(self.converter.convert(9), "IX") - self.assertEqual(self.converter.convert(21), "XXI") - self.assertEqual(self.converter.convert(50), "L") - self.assertEqual(self.converter.convert(100), "C") - self.assertEqual(self.converter.convert(500), "D") - self.assertEqual(self.converter.convert(1000), "M") - - def test_inivalid_numbers(self): - self.assertEqual(self.converter.convert(6), "") - self.assertEqual(self.converter.convert(99), "") - self.assertEqual(self.converter.convert(-1), "") if __name__ == "__main__": unittest.main() \ No newline at end of file diff --git a/muhamed_directory/other/lasse/__pycache__/romannumerals.cpython-311.pyc b/muhamed_directory/other/lasse/__pycache__/romannumerals.cpython-311.pyc new file mode 100644 index 0000000000000000000000000000000000000000..e35a47460f8afc738035f41691260dfbf6c72572 Binary files /dev/null and b/muhamed_directory/other/lasse/__pycache__/romannumerals.cpython-311.pyc differ diff --git a/muhamed_directory/other/lasse/romannumerals.py b/muhamed_directory/other/lasse/romannumerals.py index 3f3eaf1e8e956ca023c64ae71e38caefb1198940..7f486fdcc235460c8954a77ae0cd6589e9f81775 100644 --- a/muhamed_directory/other/lasse/romannumerals.py +++ b/muhamed_directory/other/lasse/romannumerals.py @@ -1,5 +1,9 @@ -from src.interfaces import IRomanNumerals +from abc import ABC, abstractmethod +class IRomanNumerals(ABC): + @abstractmethod + def to_roman(self, num): + pass class RomanNumerals(IRomanNumerals): def to_roman(self, num): diff --git a/report.md b/report.md index ed321e58ef0d8df7086bbce9d8f68f66cd65cbd2..f50e4b7fcb5b284bde31bff3bb21ce8fb86b2150 100644 --- a/report.md +++ b/report.md @@ -5,4 +5,5 @@ | Daniel | yes | all | Die Tests rufen Converter.convert() als statische Methode auf, aber die convert-Methode aus Skript 1 ist eine Instanzmethode, die eine Objektinstanz (self) benötigt. Dieser falsche Aufruf verursacht bei jedem der 7 Tests einen TypeError, weil das erwartete self-Argument fehlt. | | Ich vs Daniel Tests | no | none | | Hatice | yes | all | TypeError: RomanNumber.convert() missing 1 required positional argument: 'n' | -| ich vs Hatice Tests | no | 1 | FAIL: test_inivalid_numbers (__main__.TestRomanConverter.test_inivalid_numbers) | \ No newline at end of file +| ich vs Hatice Tests | no | 1 | FAIL: test_inivalid_numbers (__main__.TestRomanConverter.test_inivalid_numbers) | +| Lasse | yes | all | TypeError: RomanNumerals.to_roman() missing 1 required positional argument: 'num' |