From 873de44ae31ce3e73ce5f62c9e4b1943a5def208 Mon Sep 17 00:00:00 2001
From: DaniRafeh28 <daniel.rafeh@student.reutlingen-university.de>
Date: Fri, 4 Apr 2025 15:31:04 +0200
Subject: [PATCH] 4/6 Tests failed - Report Table adjusted
---
.../other/PikkemaatLasse/romannumerals.py | 6 +++++-
Project_tests/report.md | 18 +++++++++---------
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/Project_tests/other/PikkemaatLasse/romannumerals.py b/Project_tests/other/PikkemaatLasse/romannumerals.py
index 9f732d0..34dfded 100644
--- a/Project_tests/other/PikkemaatLasse/romannumerals.py
+++ b/Project_tests/other/PikkemaatLasse/romannumerals.py
@@ -1,4 +1,7 @@
from abc import ABC, abstractmethod
+import sys
+sys.path.append('C:/Users/HP/OneDrive/Praxisprojekt Semester 6/praxisprojekt-technologiebasierte-innovationen')
+from Project_tests.converter import DanisConverter as DaniConv
class IRomanNumerals(ABC):
@abstractmethod
@@ -32,7 +35,8 @@ import unittest
class TestRomanNumerals(unittest.TestCase):
def setUp(self):
- self.converter = RomanNumerals()
+ self.converter = DaniConv()
+ self.converter.to_roman = self.converter.convert
def test_to_roman_basic(self):
self.assertEqual(self.converter.to_roman(1), "I")
diff --git a/Project_tests/report.md b/Project_tests/report.md
index c9f75f3..2f8ca41 100644
--- a/Project_tests/report.md
+++ b/Project_tests/report.md
@@ -12,12 +12,12 @@ Roman Numbers - Codes of Group members tested with my testcases:
Roman Numbers - My Codes tested with other students testcases:
-| Name | Interface break | Failed Testcases |
-|------------------|-----------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| AliciMuhamed | no | 1/7 Tests failed (test_1999) |
-| BerishaAlma | no | none |
-| GotsisWasilios | no | 3/7 Tests failed (test_convert_string because the message is not equal, test_convert_empty also the return message is not equal, test_convert_downzero also because of the unequal return message) |
-| PikkemaatLasse | | |
-| YildirimHatice | | |
-| WeishauptOrlando | | |
-| SerchimoMarvin | - | - |
\ No newline at end of file
+| Name | Interface break | Failed Testcases |
+|------------------|-----------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| AliciMuhamed | no | 1/7 Tests failed (test_1999) |
+| BerishaAlma | no | none |
+| GotsisWasilios | no | 3/7 Tests failed (test_convert_string because the message is not equal, test_convert_empty also the return message is not equal, test_convert_downzero also because of the unequal return message) |
+| PikkemaatLasse | no | 4/6 Tests failed (test_to_roman_subtraction the code does not subtract properly, test_to_roman_mixed the code doesn´t convert 400 properly (CCCC != CD), test_to_roman_large_numbers same problem with CCCC again, test_to_roman_invalid the test raises value errors in my code there´s a return message to handle "errors") |
+| YildirimHatice | | |
+| WeishauptOrlando | | |
+| SerchimoMarvin | - | - |
\ No newline at end of file
--
GitLab